Repository navigation
Join preloader workers when the reader is dropped - #39
Open
communism420 wants to merge 1 commit into
Open
communism420 wants to merge 1 commit into
communism420 wants to merge 1 commit into
Conversation
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping the last reader currently detaches preloader workers, and explicit shutdown can wait with the request sender still alive. Disconnect the original request/statistics channels first, then join every worker. A running read finishes before shutdown returns.
The regression checks channel closure and joining two workers. On Windows x64 / Rust 1.99,
cargo test --locked -p nod --lib --target x86_64-pc-windows-msvcpassed 16 tests; adding--no-default-featurespassed 15. This is independent of the read-ahead changes in #27.Additional release validation of #38–#43 combined on wiidev/nod@9a7a6b2 passed 24 library tests (20 with no default features). These are combined-build results, separate from the standalone branch checks above.
Developed with AI assistance.